Fix minor sample track playback/export glitches #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches some signal-slot connections to Qt::DirectConnection. Now LMMS can handle loop points correctly and export samples without glitches. Also tweaks some Mixer-related code to avoid related deadlocks on export.
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Switches some signal-slot connections to Qt::DirectConnection. Now LMMS can handle loop points correctly and export samples without glitches. Also tweaks some Mixer-related code to avoid related deadlocks on export.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes LMMS handle loop points correctly and export samples without glitches. Switches some signal-slot connections to
Qt::DirectConnectionand changeSong::processNextBufferto emit theupdateSampleTrackssignal correctly. I believe queued connections caused #3133 (comment), so I removed the old workaround.Also tweaks some Mixer-related code to avoid deadlocks on export. Due to how
Mixer::requestChangeInModelworks, Mixer's processing state should be set properly based on whetherMixer::renderNextBuffercan be called or not. So I touchedMixerandProjectRenderera bit.Fixes #4362.